fix for secret sa

values/incubator-infra-k8s-admin-prd-ase1-values.yaml

@@ -73,12 +73,16 @@ appSpec:
     chartDir: contour
     valuesDir: contour
   - name: external-secrets
-    # Fresh install, no existing release to adopt — no nameOverride
+    # Correction from an earlier version of this file: "no nameOverride
-    # needed. Replaces the Vault Agent Injector for pulling secrets into
+    # needed" was wrong. Without one, the Application (and therefore the
-    # pods. This just brings the controller up; wiring a
+    # Helm release name the chart templates with) becomes
-    # SecretStore/ClusterSecretStore to Vault as the actual backend is a
+    # "external-secrets-admin-prd" — so the controller's ServiceAccount
-    # separate step once this is healthy (needs a Kubernetes auth method
+    # actually ends up named external-secrets-admin-prd, not
-    # enabled on the Vault side first).
+    # external-secrets. secretstores/vault-backend.yaml's
+    # serviceAccountRef assumes the plain name, and Vault's role was bound
+    # to bound_service_account_names=external-secrets — both need this
+    # pinned name to match.
+    nameOverride: external-secrets
     namespace: external-secrets
     chartDir: external-secrets
     valuesDir: external-secrets